Plat 9889 : Add support in eSearch aggregations #8504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Orion-15.1.0-PLAT-9889
… Orion-15.1.0-PLAT-9889-1
MosheMaorKaltura
changed the title
ZurPHP
reviewed
Jul 9, 2019
.../providers/elastic_search/lib/api/types/aggregations/items/KalturaESearchAggregationItem.php
Outdated
Show resolved
Hide resolved
|
|
||
| private static $map_between_objects = array( | ||
| 'size', | ||
| 'fieldName' |
There was a problem hiding this comment.
$fieldName doesn't exists in this class
...rs/elastic_search/lib/api/types/aggregations/items/KalturaESearchCategoryAggregationItem.php
Outdated
Show resolved
Hide resolved
| { | ||
| $responseBucket = new KalturaESearchAggregationBucket(); | ||
| $responseBucket->fromArray($bucket); | ||
| if($fieldName === ESearchCuePointsAggregationFieldName::TYPE) |
There was a problem hiding this comment.
Should compare $fieldName to the API enum, not to the core enum as it seems to be API since we assign it to aggs->fieldName
There was a problem hiding this comment.
Checking the returned value from the core.
...s/elastic_search/lib/api/types/aggregations/items/KalturaESearchCuepointsAggregationItem.php
Outdated
Show resolved
Hide resolved
plugins/search/providers/elastic_search/lib/elasticSearchUtils.php
Outdated
Show resolved
Hide resolved
| @@ -1,215 +1,224 @@ | |||
| <?php | |||
There was a problem hiding this comment.
for some reason, it thinks you changed the whole file is there a way to prevent it?
plugins/search/providers/elastic_search/lib/model/search/kBaseSearch.php
Outdated
Show resolved
Hide resolved
plugins/search/providers/elastic_search/services/ESearchService.php
Outdated
Show resolved
Hide resolved
plugins/search/providers/elastic_search/services/ESearchService.php
Outdated
Show resolved
Hide resolved
gotlieb
reviewed
Jul 10, 2019
| $agg->fieldName = $fieldName; | ||
| $agg->name = ESearchCategoryAggregationItem::KEY; | ||
| $bucketsArray = new KalturaESearchAggregationBucketsArray(); | ||
| $buckets = $coreResponse[ESearchAggregations::BUCKETS]; |
There was a problem hiding this comment.
$coreResponse should be validated.
gotlieb
reviewed
Jul 10, 2019
...rs/elastic_search/lib/api/types/aggregations/items/KalturaESearchCategoryAggregationItem.php
Show resolved
Hide resolved
gotlieb
reviewed
Jul 10, 2019
...iders/elastic_search/lib/api/types/aggregations/items/KalturaESearchEntryAggregationItem.php
Outdated
Show resolved
Hide resolved
gotlieb
reviewed
Jul 10, 2019
| */ | ||
| protected $size; | ||
|
|
||
| protected $fieldName; |
gotlieb
reviewed
Jul 10, 2019
| $this->size = $size; | ||
| } | ||
|
|
||
| public function getFieldName() |
gotlieb
reviewed
Jul 10, 2019
| return $this->fieldName; | ||
| } | ||
|
|
||
| public function setFieldName($fieldName) |
...s/elastic_search/lib/api/types/aggregations/items/KalturaESearchCuepointsAggregationItem.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.